sfc-gh-madkins commented on pull request #16420: URL: https://github.com/apache/airflow/pull/16420#issuecomment-861078110
That does make sense. I like that. On Mon, Jun 14, 2021 at 5:18 PM Kaxil Naik ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In airflow/providers/snowflake/hooks/snowflake.py > <https://github.com/apache/airflow/pull/16420#discussion_r651315105>: > > > @@ -179,6 +179,7 @@ def _get_conn_params(self) -> Dict[str, Optional[str]]: > > "role": self.role or role, > > "authenticator": self.authenticator or authenticator, > > "session_parameters": self.session_parameters or session_parameters, > > + "application": "AIRFLOW", > > > I was hoping we could use: AIRFLOW_SNOWFLAKE_PARTNER or a similar > environment variable so even the partners don't need to change the > provider, what do you think? > > Example: > ⬇️ Suggested change > > - "application": "AIRFLOW", > > + "application": os.environ.get("AIRFLOW_SNOWFLAKE_PARTNER", "AIRFLOW"), > > > So it default to AIRFLOW and your partners just need to add that > Environment variable in their image, example: > > AIRFLOW_SNOWFLAKE_PARTNER=AWS > > > or > > AIRFLOW_SNOWFLAKE_PARTNER=Astronomer > > > or > > AIRFLOW_SNOWFLAKE_PARTNER=GCP > > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/airflow/pull/16420#pullrequestreview-683400553>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ATSRCU4YQ7M6ND54UGGU333TSZ54NANCNFSM46TNNUEQ> > . > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
