jedcunningham commented on a change in pull request #16517:
URL: https://github.com/apache/airflow/pull/16517#discussion_r654044465
##########
File path: chart/templates/flower/flower-service.yaml
##########
@@ -44,9 +44,12 @@ spec:
component: flower
release: {{ .Release.Name }}
ports:
+ {{- if .Values.flower.service.portsOverride }}
+ {{- toYaml .Values.flower.service.portsOverride | nindent 4 }}
+ {{- else }}
- name: flower-ui
- protocol: TCP
port: {{ .Values.ports.flowerUI }}
Review comment:
I initially tried moving the default into values.yaml and templating it,
but got stuck with port being a string instead of an int. This was the best I
could come up with, but open to other options.
e.g., this doesn't work
```
# values.yaml
webserver:
service:
ports:
- name: flower-ui
port: "{{ .Values.ports.flowerUI }}"
```
Helm does have an `int`, but that only works in actual templates, not values
passed through `tpl`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
