ashb commented on a change in pull request #5048: [AIRFLOW-3370] Add stdout
output options to Elasticsearch task log handler
URL: https://github.com/apache/airflow/pull/5048#discussion_r275876137
##########
File path: airflow/utils/log/es_task_handler.py
##########
@@ -101,7 +124,11 @@ def _read(self, ti, try_number, metadata=None):
next_offset = offset if not logs else logs[-1].offset
- metadata['offset'] = next_offset
+ # Ensure a string here. Large offset numbers will get JSON.parsed
incorretly
Review comment:
```suggestion
# Ensure a string here. Large offset numbers will get JSON.parsed
incorrectly
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
