potiuk commented on issue #16541:
URL: https://github.com/apache/airflow/issues/16541#issuecomment-864541688


   > But echoing Ash’s comment, is this dependency even needed? I quickly 
checked flask-caching’s source code and it doesn’t seem to do anything magic 
during initialisation and needs explicit opt in to be effective. I quicked 
searched and didn’t find it used anywhere. Maybe we should consider removing it 
entirely?
   
   > @uranusjr plugins can still use this so we have to be careful when 
deleting this dependency.
   
   I would be for it if we can 👍.  I agree with @mik-laj that if plugins are 
using it, this migh be a problem - some plugins might add some complex 
rendering, and there caching might be an important optimization. Rather than 
entirely removing, maybe we could simply add another option "webserver -> 
enable_caching` which will be disabled by default. This is a low-risk change 
for 2.2 release maybe. If people will notice their  2.2 webserver introduced 
waiting time if they have custom plugins, we could explicitly add it the 
release notes to enable caching in this case. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to