ashb commented on a change in pull request #16581:
URL: https://github.com/apache/airflow/pull/16581#discussion_r655991696
##########
File path: airflow/jobs/scheduler_job.py
##########
@@ -817,16 +208,16 @@ def _change_state_for_tis_without_dagrun(
"""
tis_changed = 0
query = (
- session.query(models.TaskInstance)
- .outerjoin(models.TaskInstance.dag_run)
- .filter(models.TaskInstance.dag_id.in_(list(self.dagbag.dag_ids)))
- .filter(models.TaskInstance.state.in_(old_states))
+ session.query(TI)
Review comment:
I think I'd rather we kept this as `TaskInstance` or
`models.TaskInstance` instead of `TI`.
But either way _this_ type of change should be in a different PR -- this is
already a big PR, so keeping changes to a minimum helps the reviewer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
