uranusjr commented on pull request #16577:
URL: https://github.com/apache/airflow/pull/16577#issuecomment-865906553


   Thanks for the clarification. Excluding the file from sdist sounds 
reasonable to me from the justification above, so +1 to this PR on its own. The 
only remaining issue I have is why `compile_assets.sh` is currently included in 
*wheels* right now, and why this PR can successfully exclude the file, since my 
understanding is MANIFEST.in is not supposed to affect that. There are probably 
some weird setuptools mechanisms I’m not understanding correctly, I will need 
to dig into it more.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to