baolsen commented on a change in pull request #16589:
URL: https://github.com/apache/airflow/pull/16589#discussion_r657092331
##########
File path: tests/providers/amazon/aws/operators/test_datasync.py
##########
@@ -710,7 +710,7 @@ def test_killed_task(self, mock_wait, mock_get_conn):
# ### Begin tests:
# Kill the task when doing wait_for_task_execution
- def kill_task(*args):
+ def kill_task(*args, **kwargs):
Review comment:
Thanks for the feedback, yes it is needed.
Without it, the test fails:
`E TypeError: kill_task() got an unexpected keyword argument
'max_iterations'`
We are mocking `AWSDataSyncHook::wait_for_task_execution` which takes the
kwarg `max_iterations` (unchanged)
On `AWSDataSyncOperator` line 364 we are passing this kwarg for the first
time, so the mock needs to be able to receive it also. (changed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
