uranusjr commented on a change in pull request #16609:
URL: https://github.com/apache/airflow/pull/16609#discussion_r657212851
##########
File path: airflow/api_connexion/endpoints/user_endpoint.py
##########
@@ -62,3 +64,43 @@ def get_users(limit, order_by='id', offset=None):
users = query.offset(offset).limit(limit).all()
return user_collection_schema.dump(UserCollection(users=users,
total_entries=total_entries))
+
+
[email protected]_access([(permissions.ACTION_CAN_CREATE,
permissions.RESOURCE_USER)])
+def post_user():
+ """Create a new user"""
Review comment:
I kind of feel 400 is not appropriate, since the API client does not
know whether a server allows registration or not. I’ll use 403 for now since
MDN’s description seems to somehow make sense in this context:
> The access is permanently forbidden and tied to the application logic,
such as insufficient rights to a resource.
https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/403
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
