milton0825 commented on a change in pull request #5102: [AIRFLOW-4318] Create Google Cloud Translate Speech Operator URL: https://github.com/apache/airflow/pull/5102#discussion_r276100196
########## File path: airflow/contrib/operators/gcp_translate_speech_operator.py ########## @@ -0,0 +1,156 @@ +# -*- coding: utf-8 -*- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from google.protobuf.json_format import MessageToDict + + +from airflow import AirflowException +from airflow.contrib.hooks.gcp_speech_to_text_hook import GCPSpeechToTextHook +from airflow.contrib.hooks.gcp_translate_hook import CloudTranslateHook +from airflow.models import BaseOperator +from airflow.utils.decorators import apply_defaults + + +class GcpTranslateSpeechOperator(BaseOperator): + """ + Recognizes speech in audio input and translates it. + + Note that it uses the first result from the recognition api response - the one with the highest confidence + In order to see other possible results please use + :ref:`howto/operator:GcpSpeechToTextRecognizeSpeechOperator` + and + :ref:`howto/operator:CloudTranslateTextOperator` + separately + + .. seealso:: + For more information on how to use this operator, take a look at the guide: + :ref:`howto/operator:GcpTranslateSpeechOperator` + + See https://cloud.google.com/translate/docs/translating-text + + Execute method returns string object with the translation + + This is a list of dictionaries queried value. + Dictionary typically contains three keys (though not + all will be present in all cases). + + * ``detectedSourceLanguage``: The detected language (as an + ISO 639-1 language code) of the text. + * ``translatedText``: The translation of the text into the + target language. + * ``input``: The corresponding input value. + * ``model``: The model used to translate the text. + + Dictionary is set as XCom return value. + + :param audio: audio data to be recognized. See more: + https://googleapis.github.io/google-cloud-python/latest/speech/gapic/v1/types.html#google.cloud.speech_v1.types.RecognitionAudio + :type audio: dict or google.cloud.speech_v1.types.RecognitionAudio + + :param config: information to the recognizer that specifies how to process the request. See more: + https://googleapis.github.io/google-cloud-python/latest/speech/gapic/v1/types.html#google.cloud.speech_v1.types.RecognitionConfig + :type config: dict or google.cloud.speech_v1.types.RecognitionConfig + + :type target_language: str + :param target_language: The language to translate results into. This + is required by the API and defaults to + the target language of the current instance. + + :type format_: str or None + :param format_: (Optional) One of ``text`` or ``html``, to specify + if the input text is plain text or HTML. + + :type source_language: str or None + :param source_language: (Optional) The language of the text to + be translated. + + :type model: str or None + :param model: (Optional) The model used to translate the text, such + as ``'base'`` or ``'nmt'``. + + :param project_id: Optional, Google Cloud Platform Project ID where the Compute + Engine Instance exists. If set to None or missing, the default project_id from the GCP connection is + used. + :type project_id: str + + :param gcp_conn_id: Optional, The connection ID used to connect to Google Cloud + Platform. Defaults to 'google_cloud_default'. + :type gcp_conn_id: str + """ + + # [START translate_speech_template_fields] + template_fields = ('target_language', 'format_', 'source_language', 'model', 'project_id', 'gcp_conn_id') + # [END translate_speech_template_fields] + + @apply_defaults + def __init__( + self, + audio, + config, + target_language, + format_, + source_language, + model, + project_id=None, + gcp_conn_id='google_cloud_default', + *args, + **kwargs + ): + super(GcpTranslateSpeechOperator, self).__init__(*args, **kwargs) + self.audio = audio + self.config = config + self.target_language = target_language + self.format_ = format_ + self.source_language = source_language + self.model = model + self.project_id = project_id + self.gcp_conn_id = gcp_conn_id + + def execute(self, context): + _speech_to_text_hook = GCPSpeechToTextHook(gcp_conn_id=self.gcp_conn_id) + _translate_hook = CloudTranslateHook(gcp_conn_id=self.gcp_conn_id) + + recognize_result = _speech_to_text_hook.recognize_speech( + config=self.config, audio=self.audio + ) + recognize_dict = MessageToDict(recognize_result) + + if len(recognize_dict['results']) == 0: + self.log.info("No recognition results") + return {} + + try: + transcript = recognize_dict['results'][0]['alternatives'][0]['transcript'] + except KeyError as key: + raise AirflowException("Wrong response '{}' returned - it should contain {} field" + .format(recognize_dict, key)) + + try: + translation = _translate_hook.translate( + values=transcript, + target_language=self.target_language, + format_=self.format_, + source_language=self.source_language, + model=self.model + ) + self.log.info('translated output: {}'.format(translation)) Review comment: Avoid formatting the string before passing to the logger. In case the message does not need to be logged, the full string still got initialized. ```suggestion self.log.info('translated output: %s',translation) ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
