ferruzzi edited a comment on pull request #16571:
URL: https://github.com/apache/airflow/pull/16571#issuecomment-866095317
Hi Ash, thanks for the quick look. I'll hit your comments inline, but as
far as this one:
> Can you explain why you had to change the label-when-reviewed action in
this PR?
I actually never manually changed that file. It kept getting flagged as a
changed file but git would never show me the diff or allow me to roll it back
so I thought those changes kept coming from upstream. If that isn't the case,
and it sounds like it wasn't since you are asking, I'll pull that file from the
commit.
[EDIT]
Did some digging and it looks like that submodule got tied to.........
something.
```
ferruzzi:~/workplace/airflow (eksP0)
$ cat .gitmodules
[submodule ".github/actions/get-workflow-origin"]
path = .github/actions/get-workflow-origin
url = https://github.com/potiuk/get-workflow-origin
[submodule ".github/actions/checks-action"]
path = .github/actions/checks-action
url = https://github.com/LouisBrunner/checks-action
[submodule ".github/actions/configure-aws-credentials"]
path = .github/actions/configure-aws-credentials
url = https://github.com/aws-actions/configure-aws-credentials
[submodule ".github/actions/codecov-action"]
path = .github/actions/codecov-action
url = https://github.com/codecov/codecov-action
[submodule ".github/actions/github-push-action"]
path = .github/actions/github-push-action
url = https://github.com/ad-m/github-push-action
[submodule ".github/actions/label-when-approved-action"]
path = .github/actions/label-when-approved-action
url = https://github.com/TobKed/label-when-approved-action
ferruzzi:~/workplace/airflow (eksP0)
$ git submodule status
9f02872da71b6f558c6a6f190f925dde5e4d8798 .github/actions/checks-action
(v1.1.0)
1fc7722ded4708880a5aea49f2bfafb9336f0c8d .github/actions/codecov-action
(v1.1.1)
e97d7fbc8e0e5af69631c13daa0f4b5a8d88165b
.github/actions/configure-aws-credentials (v1.5.5)
588cc14f9f1cdf1b8be3db816855e96422204fec
.github/actions/get-workflow-origin (v1_3)
40bf560936a8022e68a3c00e7d2abefaf01305a6 .github/actions/github-push-action
(v0.6.0)
4c5190fec5661e98d83f50bbd4ef9ebb48bd1194
.github/actions/label-when-approved-action (latest)
$ git remote -v
origin https://github.com/TobKed/label-when-approved-action (fetch)
origin https://github.com/TobKed/label-when-approved-action (push)
```
I pulled that submodule and it looks like that may have been the issue.
```
Updating 4c5190f..0058d00
Fast-forward
.github/workflows/test.yml | 1 +
.pre-commit-config.yaml | 2 +-
README.md | 21 +-
action.yml | 5 +-
dist/index.js | 37 ++-
package-lock.json | 3248
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-----------------------------------
package.json | 3 +-
scripts/transpile_if_needed.sh | 19 ++
src/main.ts | 26 +-
transpilation_state/main.ts.md5sum | 1 +
tsconfig.json | 2 +-
11 files changed, 2725 insertions(+), 640 deletions(-)
create mode 100755 scripts/transpile_if_needed.sh
create mode 100644 transpilation_state/main.ts.md5sum
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
