zhangyi-hu commented on a change in pull request #16617:
URL: https://github.com/apache/airflow/pull/16617#discussion_r658093334
##########
File path: airflow/utils/dag_cycle_tester.py
##########
@@ -25,6 +25,21 @@
def test_cycle(dag):
+ """
+ A wrapper function of `check_cycle` for backward compatibility purpose.
+ New code should use `check_cycle` instead since this function name
`test_cycle` starts with 'test_' and
+ will be considered as a unit test by pytest, resulting in failure.
+ """
+ from warnings import warn
Review comment:
We discourage the usage of this function and warn that it is deprecated,
as a result, its usage can be predicted to be rare. This 'warn' is only used
here so doesn't need to be imported at the module level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
