ecerulm opened a new pull request #16678: URL: https://github.com/apache/airflow/pull/16678
<!-- Thank you for contributing! Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping committers for the review! In case of existing issue, reference it using one of the following: closes: #ISSUE related: #ISSUE How to write a good git commit message: http://chris.beams.io/posts/git-commit/ --> closes: #16613 related: #16631 This allows to specify a pendulum timezone for the DAG which is used to qualify the `schedule_interval`. Currently the dag timezone is inferred from the dag's `start_date` but that runs into the problem that in that case the timeone is a `datetime.tzinfo` which is not really serializable. Up till now airflow was relying in trying to get the tzinfo's name and serializing that, hoping that you could get an equivalent tzinfo via `pendulum.timezone(serialized_name)`. The idea behind this PR is to introduce a more direct way to specify the timezone for the DAG, and require it to be a pendulum's timezone name (IANA timezone strings) or an offset in seconds. That is more reliable than trying to support serialization for generic `datetime.tzinfo` which runs into a lot of corner cases. Having said that this PR also still tries to infer a `schedule_timezone` string from the `start_date` if not directly supplied: * use `start_date.tzinfo.name` if exist and it's recognized by pendulum as valid timezone identifier * use `start_date.tzinfo.tzname(...)` if it's recognized by pendulum as valid timezone identifier * use the `start_date.tzinfo.utcoffset(...)` --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information. In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
