ashb commented on a change in pull request #16674:
URL: https://github.com/apache/airflow/pull/16674#discussion_r659724744
##########
File path: scripts/ci/libraries/_build_images.sh
##########
@@ -743,8 +743,8 @@ function build_images::prepare_prod_build() {
build_images::add_build_args_for_remote_install
elif [[ -n "${INSTALL_AIRFLOW_VERSION=}" ]]; then
# When --install-airflow-version is used then the image is build using
released PIP package
- # For PROD image only numeric versions are allowed
- if [[ ! ${INSTALL_AIRFLOW_VERSION} =~ ^[0-9\.]*$ ]]; then
+ # For PROD image only numeric versions are allowed and RC candidates
+ if [[ ! ${INSTALL_AIRFLOW_VERSION} =~ ^[0-9\.]*(rc[0-9]*)?$ ]]; then
Review comment:
(Assuming bash regex work this way)
##########
File path: tests/jobs/test_scheduler_job.py
##########
@@ -3650,7 +3650,7 @@ def test_task_with_upstream_skip_process_task_instances():
assert dr is not None
with create_session() as session:
- tis = {ti.task_id: ti for ti in dr.get_task_instances(session=session)}
+ tis = {ti.task_id: ti for ti in
dr.get_task_instances(session=session)} # pylint: disable=no-member
Review comment:
Not needed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
