ashb commented on a change in pull request #16401: URL: https://github.com/apache/airflow/pull/16401#discussion_r660021617
########## File path: airflow/migrations/versions/a84a5abfca95_update_dagrun_state_and_datetime.py ########## @@ -0,0 +1,122 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +"""update-dagrun-state-and-datetime + +Revision ID: a84a5abfca95 +Revises: 30867afad44a +Create Date: 2021-06-13 11:08:18.705168 + +""" +import sqlalchemy as sa +from alembic import op +from sqlalchemy.dialects import mysql + +from airflow.utils.dates import timezone +from airflow.utils.state import State + +# revision identifiers, used by Alembic. +revision = 'a84a5abfca95' +down_revision = '30867afad44a' +branch_labels = None +depends_on = None + + +def upgrade(): + """Apply Set default start_time for dagrun to None and set default state to QUEUED""" + conn = op.get_bind() + if conn.dialect.name == "mysql": + conn.execute("SET time_zone = '+00:00'") + cur = conn.execute("SELECT @@explicit_defaults_for_timestamp") + res = cur.fetchall() + if res[0][0] == 0: + raise Exception("Global variable explicit_defaults_for_timestamp needs to be on (1) for mysql") + op.alter_column( + 'dag_run', + 'start_date', + type_=mysql.DATETIME(fsp=6), + existing_server_default=timezone.utcnow(), + server_default=None, + ) + + else: + # sqlite and mssql datetime are fine as is. Therefore, not converting + if conn.dialect.name in ("sqlite", "mssql"): + return Review comment: We're changing the default aren't we -- that should apply equally to all database types ########## File path: airflow/models/taskinstance.py ########## @@ -237,7 +237,8 @@ def clear_task_instances( ) for dr in drs: dr.state = dag_run_state - dr.start_date = timezone.utcnow() + dr.start_date = None + dr.last_scheduling_decision = None Review comment: Oh, _technically_ someone could set a state other than queued here -- so maybe we need an `if dag_run_state == State.QUEUED: ... else: ...` here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
