uranusjr commented on a change in pull request #16404:
URL: https://github.com/apache/airflow/pull/16404#discussion_r660197969
##########
File path: airflow/models/connection.py
##########
@@ -35,6 +36,8 @@
from airflow.utils.log.secrets_masker import mask_secret
from airflow.utils.module_loading import import_string
+log = logging.getLogger()
Review comment:
Use `getLogger(__file__)` to give the logger a name. Otherwise it
returns the root logger, making the log messages very difficult to manage.
##########
File path: airflow/models/connection.py
##########
@@ -35,6 +36,8 @@
from airflow.utils.log.secrets_masker import mask_secret
from airflow.utils.module_loading import import_string
+log = logging.getLogger()
Review comment:
Use `getLogger(__name__)` to give the logger a name. Otherwise it
returns the root logger, making the log messages very difficult to manage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
