ashb commented on a change in pull request #16571: URL: https://github.com/apache/airflow/pull/16571#discussion_r660436996
########## File path: airflow/providers/amazon/aws/hooks/eks.py ########## @@ -0,0 +1,346 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# pylint: disable=invalid-name +"""Interact with Amazon EKS, using the boto3 library.""" + +import json +from typing import Dict, List, Optional + +from botocore.exceptions import ClientError + +from airflow.providers.amazon.aws.hooks.base_aws import AwsBaseHook +from airflow.utils.json import AirflowJsonEncoder + +DEFAULT_RESULTS_PER_PAGE = 100 +DEFAULT_PAGINATION_TOKEN = '' + + +class EksHook(AwsBaseHook): + """ + Interact with Amazon EKS, using the boto3 library. + + Additional arguments (such as ``aws_conn_id``) may be specified and + are passed down to the underlying AwsBaseHook. + + .. seealso:: + :class:`~airflow.providers.amazon.aws.hooks.base_aws.AwsBaseHook` + """ + + conn_type = 'eks' + conn_name = 'eks' + client_type = 'eks' + hook_name = 'EKS' + + def __init__(self, *args, **kwargs) -> None: + kwargs["client_type"] = self.client_type + super().__init__(*args, **kwargs) + + def create_cluster(self, name: str, roleArn: str, resourcesVpcConfig: Dict, **kwargs) -> Dict: + """ + Creates an Amazon EKS control plane. + + :param name: The unique name to give to your Amazon EKS Cluster. + :type name: str + :param roleArn: The Amazon Resource Name (ARN) of the IAM role that provides permissions + for the Kubernetes control plane to make calls to AWS API operations on your behalf. + :type roleArn: str + :param resourcesVpcConfig: The VPC configuration used by the cluster control plane. + :type resourcesVpcConfig: Dict + + :return: Returns descriptive information about the created EKS Cluster. + :rtype: Dict + """ + try: + eks_client = self.get_conn() + + response = eks_client.create_cluster( + name=name, roleArn=roleArn, resourcesVpcConfig=resourcesVpcConfig, **kwargs + ) + + self.log.info("Created cluster with the name %s.", response.get('cluster').get('name')) + return response + + except ClientError as e: + self.log.error(e.response["Error"]["Message"]) + raise e Review comment: Is this except useful? Given we are re-raising the error I would suggest not -- let this be handled by the caller and remove the try/except from all of these methods. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
