ashb commented on a change in pull request #16700:
URL: https://github.com/apache/airflow/pull/16700#discussion_r660483731
##########
File path: airflow/jobs/base_job.py
##########
@@ -94,8 +95,11 @@ class BaseJob(Base, LoggingMixin):
def __init__(self, executor=None, heartrate=None, *args, **kwargs):
self.hostname = get_hostname()
- self.executor = executor or ExecutorLoader.get_default_executor()
- self.executor_class = self.executor.__class__.__name__
+ self._executor = executor
+ if self._executor:
+ self.executor_class = self._executor.__class__.__name__
+ else:
+ self.executor_class = conf.get('core', 'EXECUTOR')
Review comment:
Can be much simpler
```suggestion
if executor:
self.executor
```
##########
File path: airflow/jobs/base_job.py
##########
@@ -104,6 +108,11 @@ def __init__(self, executor=None, heartrate=None, *args,
**kwargs):
self.max_tis_per_query = conf.getint('scheduler', 'max_tis_per_query')
super().__init__(*args, **kwargs)
+ @cached_property
+ def executor(self):
+ """Provided Executor which defaults to the one mentioned via Airflow
configuration"""
+ return self._executor or ExecutorLoader.get_default_executor()
+
Review comment:
```suggestion
@cached_property
def executor(self):
return ExecutorLoader.get_default_executor()
@property
def executor_class(self):
return self.executor.__class__.__name__
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
