[GitHub] [airflow] mik-laj commented on a change in pull request #16571: Implemented Basic EKS Integration

[GitBox]

mik-laj commented on a change in pull request #16571:
URL: https://github.com/apache/airflow/pull/16571#discussion_r661037265



##########
File path: docs/apache-airflow-providers-amazon/operators/eks.rst
##########
@@ -0,0 +1,265 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+    or more contributor license agreements.  See the NOTICE file
+    distributed with this work for additional information
+    regarding copyright ownership.  The ASF licenses this file
+    to you under the Apache License, Version 2.0 (the
+    "License"); you may not use this file except in compliance
+    with the License.  You may obtain a copy of the License at
+
+ ..   http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+    software distributed under the License is distributed on an
+    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+    KIND, either express or implied.  See the License for the
+    specific language governing permissions and limitations
+    under the License.
+
+
+Amazon Elastic Kubernetes Service (EKS) Operators
+=================================================
+
+`Amazon Elastic Kubernetes Service (Amazon EKS) 
<https://aws.amazon.com/eks/>`__  is a managed service
+that makes it easy for you to run Kubernetes on AWS without needing to stand 
up or maintain your own
+Kubernetes control plane. Kubernetes is an open-source system for automating 
the deployment, scaling,
+and management of containerized applications.
+
+.. contents::
+  :depth: 1
+  :local:
+
+Prerequisite Tasks
+------------------
+
+.. include:: _partials/prerequisite_tasks.rst
+
+Overview
+--------
+
+Airflow to Amazon Elastic Kubernetes Service (EKS) integration provides 
Operators to create and
+interact with the EKS clusters and compute infrastructure.
+
+ - :class:`~airflow.providers.amazon.aws.operators.eks`
+
+4 example_dags are provided which showcase these operators in action.
+
+ - ``example_eks_create_cluster.py``
+ - ``example_eks_create_cluster_with_nodegroup.py``
+ - ``example_eks_create_nodegroup.py``
+ - ``example_eks_pod_operator.py``
+
+
+.. _howto/operator:EKSCreateClusterOperator:
+
+Creating Amazon EKS Clusters
+----------------------------
+
+Purpose
+"""""""
+
+This example dag ``example_eks_create_cluster.py`` uses 
``EKSCreateClusterOperator`` to create an Amazon

Review comment:
       I've mentioned this before, but we shouldn't be covering the individual 
sample files.
   https://github.com/apache/airflow/pull/16571#discussion_r659253383
   If you are using the exampleinclude directive, each code snippet has a 
button that allows you to go to the source code.
   <img width="931" alt="Screenshot 2021-06-30 at 01 41 49" 
src="https://user-images.githubusercontent.com/12058428/123881125-5f9c1480-d944-11eb-8fb4-1b07cdb82e83.png";>
   A similar approach is used by other organizations:
   
https://docs.aws.amazon.com/sdk-for-java/v1/developer-guide/examples-s3-objects.html
   
https://cloud.google.com/storage/docs/reporting-changes#storage_delete_bucket_notification-cpp
   <img width="905" alt="Screenshot 2021-06-30 at 01 53 06" 
src="https://user-images.githubusercontent.com/12058428/123881912-f3221500-d945-11eb-9de1-717deaf9a7d5.png";>
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org