pmalafosse commented on pull request #16685: URL: https://github.com/apache/airflow/pull/16685#issuecomment-872048609
> This flag doesn't seem like a good idea. I agree with the underlying issue this is trying to solve. > What about just updating `reattach` directly with this new logic? The flag only has a simple use case in mind with no consideration for concurrency, and that was okay at that time. > > A more abrupt approach would be forcing every ECS task to take the name `airflow + dag_id + task_id` and have `reattach` check on that. Yes that makes sense, I will update 'reattach' logic directly then, I was not sure if it had an other user case I hadn't thought about. Unfortunately we can't define the ECS task_id from our side, it is a unique ID generated by Amazon (and if we could there would be problems with retries and clearing tasks anyway). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
