potiuk commented on pull request #16776: URL: https://github.com/apache/airflow/pull/16776#issuecomment-873574234
> Can’t say I understand some of the bash stuff but as far a I can tell this is good to merge. Yeah. Once we simplify some of that I hope we can finally rewrite it in Python: #12282. This image building and caching done efficiently for development will now be much easier. Some of the complexity I am removing now was because we used both GitHub Packages (For CI) and DockerHub (for Breeze). That was because we did not want to have additional authentication for DockerHub pushing images from CI (and we ere afraid it won't handle the per-build CI images we have). On the other hand, GitHub Packages did not have the option of "Public" images. Now with `ghcr.io` which was promoted to GA recently, we have both - built-in authentication using `GITHUB_TOKEN` and public images, so we can finally switch I think. I will start gradually replacing parts of the bash scripts with Python soon I think (and invite others to help) With #16780 we are switching Breeze completely to `ghcr.io` as well and then managing of images becomes much simpler, it did not make much sense to rewrite all the complexity in Python (even in Python it would be equally complex). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
