huozhanfeng commented on a change in pull request #16768:
URL: https://github.com/apache/airflow/pull/16768#discussion_r663601609
##########
File path: airflow/models/taskinstance.py
##########
@@ -1495,8 +1495,7 @@ def handle_failure(
except Exception:
self.log.exception('Failed to send email to: %s', task.email)
- if not test_mode:
- session.merge(self)
+ session.merge(self)
Review comment:
Yes, the original logic can't write task_instance info into DB/session
in ut mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
