ashb commented on a change in pull request #16182:
URL: https://github.com/apache/airflow/pull/16182#discussion_r663763775
##########
File path: tests/models/test_dagbag.py
##########
@@ -859,6 +859,39 @@ def test_get_dag_with_dag_serialization(self):
assert set(updated_ser_dag_1.tags) == {"example", "example2",
"new_tag"}
assert updated_ser_dag_1_update_time > ser_dag_1_update_time
+ @patch("airflow.models.dagbag.settings.MIN_SERIALIZED_DAG_FETCH_INTERVAL",
5)
+ def test_has_dag_method(self):
+ """Test has_dag method"""
+ dag_id = "example_bash_operator"
+ with freeze_time(tz.datetime(2020, 1, 5, 0, 0, 0)):
+ example_bash_op_dag =
DagBag(include_examples=True).dags.get(dag_id)
+ SerializedDagModel.write_dag(dag=example_bash_op_dag)
+
+ dag_bag = DagBag(read_dags_from_db=True)
+ dag_bag.get_dag(dag_id) # Add dag to self.dags
+ assert dag_bag.has_dag(dag_id)
Review comment:
We should put a query count assertion around this line to ensure it is 0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
