ferruzzi commented on pull request #16771: URL: https://github.com/apache/airflow/pull/16771#issuecomment-874935312
> > Second nitpick, I believe the three commits need to be squashed, or perhaps I misunderstood when I read that somewhere. Kamil or Jarek can confirm or refute that. > > This is not needed and I do not recommend doing this as several commits make reviews easier. Commiters do this automatically when merging PRs. Oh wow, then I am quite sorry. I was positive someone had told me to make sure I do that in my previous PR. Apologies for the frustration and the misinformation. > Thanks for the suggestion. I'm doing development on Windows which can make testing interesting. > The closest I can get to a Linux environment is WSL + Ubuntu. Ah, that does complicate things. Maybe a virtualbox running linux, but either way... not as convenient and useful as intended :P -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
