ephraimbuddy commented on pull request #16823:
URL: https://github.com/apache/airflow/pull/16823#issuecomment-875058937


   > FWIW that feels like a bug itself -- it shouldn't show up "twice" in xcom, 
which is especially important for custom xcom backends and larger data (i.e. 
DFs)
   
   Above is the current behaviour when using multiple outputs. With this change 
only this `key=return_value, value={'mykey':[3,4,56]}` is the output
   
   > For instance:
       ```
       @task
       def my_task():
             return some_large_df()
       ```
       That is very likely to be error prone to and hard to spot the error for 
anyone not intimately familiar with XComs -- the opposite direction we want to 
head in :)
   
   The above code, will output `some_large_df` as xcom value with 
key='return_value', if we use this change and say @task(xcom_key='somekey'), 
the only thing that would change is the xcom key. Xcom value will be 
`some_large_df` while key will be `somekey'.
   
   > So lets take an big step back: what feature/functionality are you trying 
to achieve?
   
   I want to be able to control the key used in pushing xcom when a value is 
returned from a task
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to