ashb commented on a change in pull request #16848:
URL: https://github.com/apache/airflow/pull/16848#discussion_r665234362
##########
File path: airflow/providers/apache/spark/hooks/spark_sql.py
##########
@@ -152,8 +160,15 @@ def _prepare_command(self, cmd: Union[str, List[str]]) ->
List[str]:
connection_cmd += ["-f", sql]
else:
connection_cmd += ["-e", sql]
- if self._master:
- connection_cmd += ["--master", self._master]
+ if len(self._conn.host) > 0:
Review comment:
If `self._master` is specified, that should be used over anything in the
connection, otherwise you are breaking existing behaviuor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
