oscarrobertson commented on pull request #15942:
URL: https://github.com/apache/airflow/pull/15942#issuecomment-875676096


   I agree that this is a breaking change, it does feel like something that 
could be made clearer in the release notes.
   
   I think the code that uses this param to check the extensions also is just 
checking `endswith`, it's not parsing to find an extension:  
   
https://github.com/apache/airflow/blob/main/airflow/models/baseoperator.py#L1047
   
   In other operators the leading `.` of the extension is included: 
https://github.com/apache/airflow/blob/main/airflow/operators/sql.py#L107
   
   This means this change is probably overly inclusive of parameters being 
considered files.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to