samgans commented on issue #16669:
URL: https://github.com/apache/airflow/issues/16669#issuecomment-875892240


   Hello again!
   
   I've made a basic investigation on it and found that we actually have a bit 
weird situation. The thing is that if you are authenticating your Tableau 
connection with a personal access token, each time you will try to open a 
parallel connection, the previous one will be invalidated. You can read more 
about this in the thread: 
https://github.com/tableau/server-client-python/issues/717.
   
   Speaking of our issue and how it is related to the Tableau personal token: 
in the "blocking" task, we are using the TableauJobStatusSensor that opens 
another connection, therefore, invalidating the previous one causing the 
wrapping TableauHook to fail (you can check more in the `execute` method of 
`TableauRefreshWorkbookOperator` in  `tableau_refresh_workbook.py`).
   
   So, we have two options here:
   
   1. As the blocking process uses an explicit sensor to wait till the job is 
finished (and the sensor opens another connection), we can make the Sensor 
configurable to use the existing connection (which is TableauHook). So, we can 
pass it as a parameter and forget about the symptom.
   
   **BUT!** It seems like if the user will add one or more Tableau task which 
will use the same token and run in parallel, we can get some hard-to-debug 
errors due to parallel invalidation of tokens. Therefore, it seems to me that 
we shouldn't use this approach and take a look at the next one.
   
   2. Just deprecate the authentication by the personal token and indicate this 
clearly in the documentation. This will remove all kinds of bugs related to the 
invalidation of access tokens and will not deceive the users about the 
operability of the execution of the parallel tasks with a personal token.
   
   What do you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to