ephraimbuddy commented on a change in pull request #16845:
URL: https://github.com/apache/airflow/pull/16845#discussion_r665862132
##########
File path: airflow/api_connexion/endpoints/task_instance_endpoint.py
##########
@@ -120,7 +114,7 @@ def get_task_instances(
end_date_lte: Optional[str] = None,
duration_gte: Optional[float] = None,
duration_lte: Optional[float] = None,
- state: Optional[str] = None,
+ state: Optional[List[str]] = None,
Review comment:
```suggestion
state: Optional[List[TaskInstanceState]] = None,
```
##########
File path: airflow/api_connexion/endpoints/dag_run_endpoint.py
##########
@@ -85,17 +94,18 @@ def get_dag_run(dag_id, dag_run_id, session):
)
@provide_session
def get_dag_runs(
- session,
- dag_id,
- start_date_gte=None,
- start_date_lte=None,
- execution_date_gte=None,
- execution_date_lte=None,
- end_date_gte=None,
- end_date_lte=None,
- offset=None,
- limit=None,
- order_by='id',
+ session: Session,
+ dag_id: str,
+ start_date_gte: Optional[str] = None,
+ start_date_lte: Optional[str] = None,
+ execution_date_gte: Optional[str] = None,
+ execution_date_lte: Optional[str] = None,
+ end_date_gte: Optional[str] = None,
+ end_date_lte: Optional[str] = None,
+ state: Optional[List[str]] = None,
Review comment:
```suggestion
state: Optional[List[DagRunState]] = None,
```
##########
File path: airflow/api_connexion/endpoints/dag_run_endpoint.py
##########
@@ -124,16 +135,17 @@ def get_dag_runs(
def _fetch_dag_runs(
- query,
- end_date_gte,
- end_date_lte,
- execution_date_gte,
- execution_date_lte,
- start_date_gte,
- start_date_lte,
- limit,
- offset,
- order_by,
+ query: Query,
+ end_date_gte: Optional[str],
+ end_date_lte: Optional[str],
+ execution_date_gte: Optional[str],
+ execution_date_lte: Optional[str],
+ start_date_gte: Optional[str],
+ start_date_lte: Optional[str],
+ state: Optional[List[str]],
Review comment:
```suggestion
state: Optional[List[DagRunState]],
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
