samgans opened a new pull request #16893:
URL: https://github.com/apache/airflow/pull/16893


   This PR closes the #16836 and is related to #12315
   
   **Why:**
   
   There was an inconsistency in the UI where the presence of XCOM value was 
checked by `elif item[value] != None`. That caused a failure in XCOMs view when 
the user was trying to return not castable to bool XCOM objects (e.g. pandas 
data frames). Moreover, the method of comparison is not recommended by PEP8:
   
   ```Comparisons to singletons like None should always be done with is or is 
not, never the equality operators.```
   
   The bug was uncovered by @turbaszek but was not fixed for some reason 
(probably due to the focus change).
   
   **Changes:**
   
   Change the comparison operator from `!=` to `is not`, which is recommended 
approach.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to