samgans commented on pull request #16916:
URL: https://github.com/apache/airflow/pull/16916#issuecomment-877844428


   Hi, @eladkal!
   
   The thing here is that personal token authentication was not working 
correctly as intended in the scope of Airflow logic, that's why we decided to 
remove it. But you are right, such a breaking change is what we can avoid at 
this stage.
   
   Therefore, I can propose to leave the changes I've done apart from removing 
the method for the authentication in the hook and tests for it. I will put it 
back and indicate the danger of using a personal token authentication approach 
in the documentation and the body of the method. Does that make sense? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to