Bennyelg commented on pull request #16954:
URL: https://github.com/apache/airflow/pull/16954#issuecomment-878900626


   @potiuk 
   
   I think this reason of not doing so is because its minimum change with 
maximum value (for now).
   due to the reason the function of pip installation is very naive, extending 
it with PyPI Connection is not enough and require a proper class code and this 
will require much more work.
   
   for now, I think passing the url including the username & password (which 
should be passed via Environment variables) is the easiest and fastest way
   
   http://{USERNAME}:{PASSWORD}@localhost:8080/repository/python/simple
   
   tried on my private repo server of course.
   
   At the end I think the solution is pretty fast & clean and along the way add 
plenty of value without introduce breaking changes.
   
   What do you think? should we still attack this differently ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to