mgorsk1 edited a comment on pull request #16945: URL: https://github.com/apache/airflow/pull/16945#issuecomment-879036645
Actually this was my first implementation if you look into commit history. The reason why I refactored is I was unsure whether having to create custom operator class is a most convenient way for users. But since it's advanced feature anyways I don't think it's a huge downside and the upside of init flexibility might be more significant. I would only change your implementation so create_pod_launcher uses kwargs to pull necessary arguments. client is something that is created by execute method so we would need to pass it from there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
