kaxil commented on a change in pull request #17011:
URL: https://github.com/apache/airflow/pull/17011#discussion_r670053767
##########
File path: scripts/in_container/prod/entrypoint_prod.sh
##########
@@ -193,30 +186,13 @@ function set_pythonpath_for_root_user() {
}
function wait_for_airflow_db() {
- # Check if Airflow has a command to check the connection to the database.
- if ! airflow db check --help >/dev/null 2>&1; then
- run_check_with_retries "airflow db check"
- else
- # Verify connections to the Airflow DB by guessing the database
address based on environment variables,
- # then uses netcat to check that the host is reachable.
- # This is only used by Airflow 1.10+ as there are no built-in commands
to check the db connection.
- local connection_url
- if [[ -n "${AIRFLOW__CORE__SQL_ALCHEMY_CONN_CMD=}" ]]; then
- connection_url="$(eval "${AIRFLOW__CORE__SQL_ALCHEMY_CONN_CMD}")"
- else
- # if no DB configured - use sqlite db by default
-
connection_url="${AIRFLOW__CORE__SQL_ALCHEMY_CONN:="sqlite:///${AIRFLOW_HOME}/airflow.db"}"
- fi
- # SQLite doesn't require a remote connection, so we don't have to wait.
- if [[ ${connection_url} != sqlite* ]]; then
- wait_for_connection "${connection_url}"
- fi
- fi
+ # Wait for the command to run successfully to validate the database
connection.
+ run_check_with_retries "airflow db check"
}
function upgrade_db() {
# Runs airflow db upgrade
- airflow db upgrade || airflow upgradedb || true
+ airflow upgradedb || true
Review comment:
```suggestion
airflow db upgrade || true
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
