ManiBharataraju commented on a change in pull request #16508:
URL: https://github.com/apache/airflow/pull/16508#discussion_r670215236
##########
File path: airflow/models/dag.py
##########
@@ -1847,7 +1847,10 @@ def bulk_write_to_db(cls, dags: Collection["DAG"],
session=None):
for missing_dag_id in missing_dag_ids:
orm_dag = DagModel(dag_id=missing_dag_id)
dag = dag_by_ids[missing_dag_id]
- if dag.is_paused_upon_creation is not None:
+
+ if dag.is_subdag:
+ orm_dag.is_paused = dag.parent_dag.get_is_paused()
+ elif dag.is_paused_upon_creation is not None:
Review comment:
> If the default is False (i.e. not paused), why is the subdag created
in the off state?
My bad, I just fixed my comment. It is true by default.
> The default dags_are_paused_at_creation value is actually True, so by
default, dags are created in in the paused state. So when the parent DAG is
unpaused, the newly-created subdag would indeed be in a different state. Is
this what you’re trying to say? (but not describing the true/false on/off
values correctly… which is understandable, the various negative value names are
difficult to keep straight)
Yes right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
