uranusjr commented on a change in pull request #16956:
URL: https://github.com/apache/airflow/pull/16956#discussion_r670880410
##########
File path: airflow/providers/cncf/kubernetes/operators/spark_kubernetes.py
##########
@@ -30,7 +30,8 @@ class SparkKubernetesOperator(BaseOperator):
For more detail about Spark Application Object have a look at the
reference:
https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/blob/v1beta2-1.1.0-2.4.5/docs/api-docs.md#sparkapplication
- :param application_file: filepath to kubernetes custom_resource_definition
of sparkApplication
+ :param application_file: either 1) a file ending in '.yaml', '.yml', or
'.json' that will be converted to the file's string contents by the templating,
or
+ 2) a JSON string defining kubernetes
custom_resource_definition of sparkApplication
Review comment:
This is restructuredText, so I don’t think the indentation and `1)` will
do what you want in the documentation. I would write this as prose, e.g.
```
Defines Kubernetes `custom_resource_definition` of `sparkApplication. Either
a path to a ``.json`` file, or a JSON string.
```
(Does YAML make sense for this field? I’m not sure.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
