nijanthanvijayakumar commented on a change in pull request #17060:
URL: https://github.com/apache/airflow/pull/17060#discussion_r671638284
##########
File path: CONTRIBUTING.rst
##########
@@ -208,27 +208,33 @@ You can configure the Docker-based Breeze development
environment as follows:
1. Install the latest versions of the Docker Community Edition
and Docker Compose and add them to the PATH.
-2. Enter Breeze: ``./breeze``
+2. Install jq on your machine, using the following command:
+
+.. code-block:: bash
+
+ sudo apt install jq
Review comment:
Thanks for the review & prompt response @uranusjr .
I am a Mac user to and I used the `brew install jq` command to install that
library. However, if you look at this `CONTRIBUTORS_QUICK_START.rst` document,
[the section that this change comes
under](https://github.com/apache/airflow/blob/main/CONTRIBUTORS_QUICK_START.rst#installing-prerequisites-on-ubuntu)
talks about `Installing prerequisites on Ubuntu`. Hence, I have limited it to
Ubuntu, to keep it consistent with the other prerequisites. My two cents is,
there should be a separate section with the prerequisite for Mac OS and this
should go in there. Let me know what you think?
##########
File path: CONTRIBUTING.rst
##########
@@ -208,27 +208,33 @@ You can configure the Docker-based Breeze development
environment as follows:
1. Install the latest versions of the Docker Community Edition
and Docker Compose and add them to the PATH.
-2. Enter Breeze: ``./breeze``
+2. Install jq on your machine, using the following command:
+
+.. code-block:: bash
+
+ sudo apt install jq
Review comment:
Thanks for the review & prompt response @uranusjr .
I am a Mac user too and I used the `brew install jq` command to install that
library. However, if you look at this `CONTRIBUTORS_QUICK_START.rst` document,
[the section that this change comes
under](https://github.com/apache/airflow/blob/main/CONTRIBUTORS_QUICK_START.rst#installing-prerequisites-on-ubuntu)
talks about `Installing prerequisites on Ubuntu`. Hence, I have limited it to
Ubuntu, to keep it consistent with the other prerequisites. My two cents is,
there should be a separate section with the prerequisite for Mac OS and this
should go in there. Let me know what you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
