flolas commented on a change in pull request #17057:
URL: https://github.com/apache/airflow/pull/17057#discussion_r671864779
##########
File path: airflow/kubernetes/kubernetes_helper_functions.py
##########
@@ -37,7 +37,7 @@ def _strip_unsafe_kubernetes_special_chars(string: str) ->
str:
:param string: The requested Pod name
:return: Pod name stripped of any unsafe characters
"""
- return ''.join(ch.lower() for ch in list(string) if ch.isalnum())
+ return ''.join(ch.lower() for ch in list(string) if
ch.isalnum()).encode('ascii', 'ignore').decode()
Review comment:
@potiuk The issue its only for the pod name, do we really need to
translate with a more complex solution? If so, i can make the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
