fatmumuhomer commented on issue #16364:
URL: https://github.com/apache/airflow/issues/16364#issuecomment-882208078
Just to be clear on the preferred usage going forward:
- SSHOperator uses two different timeouts:
- A connection timeout passed into SSHHook (see below)
- A command timeout passed into paramiko.SSHClient.exec_command() which
sets the command’s channel timeout
- SSHHook uses a single timeout:
- A connection timeout passed into paramiko.SSHClient.connect() which is a
timeout for the TCP connect.
It doesn't seem to make sense to accept a cmd_timeout in the hook, so I am
planning to do the following:
- Accept both conn_timeout and cmd_timeout in SSHOperator.
- Accept conn_timeout only in SSHHook.
- Add a deprecation warning to SSHHook for the use of timeout in
extra_options; favor conn_timeout if provided.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
