benbenbang commented on a change in pull request #5137: Add try-catch for
retrieving `status` from cli in docker operator
URL: https://github.com/apache/airflow/pull/5137#discussion_r277061075
##########
File path: airflow/operators/docker_operator.py
##########
@@ -198,9 +198,21 @@ def execute(self, context):
if self.force_pull or len(self.cli.images(name=self.image)) == 0:
self.log.info('Pulling docker image %s', self.image)
for l in self.cli.pull(self.image, stream=True):
- output = json.loads(l.decode('utf-8').strip())
- if 'status' in output:
- self.log.info("%s", output['status'])
+ try:
Review comment:
Not sure why it happened, but there’s no issue if I call the docker api
directly. I will check if I explicitly put this parameter in docker operator.
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
