sharingan-no-kakashi commented on pull request #16953: URL: https://github.com/apache/airflow/pull/16953#issuecomment-882732582
> > Indeed, it's very interesting. I am missing the context though, from where does that demo come from? Is it going to be integrated into the open-source version of airflow? > > Context: They consider contributing some of that code to Airflow - but it is based on Airflow 1.10.5 so it might as well be easier to implement it from scratch in Airflow 2 (and take inspiration from what they've done). Sometimes reuse is on the "concept reuse" level rather than "code reuse". > > > OK, I have an idea: what about having a decorator similar to action_logging which is note_logger or similar, this decorator can be used in a similar fashion to action_logging but instead of updating the logs, it will, if the note if not empty, update the "note table". > > I think decorator in this case would not work too well. What we need to do, is to mark all the actions to be "note'able" so-to-speak. so we do not want to add decorator IMHO (which adds automated logging action) but rather we need to add reusable logic for displaying the note view in FAB and some reusable code that every action that is performed should call to store the note. I am not sure if the decorator would help here. But maybe I am not getting the idea you have :). Maybe you could put together a simple POC and prepare a draft PR where you could just implement it for one action and then we could discuss how to generalise it best, and when we agree in PR you could complete it for other views and then we could merge it? > > I think that would be best way of handling it. Sounds good. I'll do it 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
