ciancolo commented on a change in pull request #17034:
URL: https://github.com/apache/airflow/pull/17034#discussion_r672057014
##########
File path: tests/providers/tableau/hooks/test_tableau.py
##########
@@ -189,3 +189,79 @@ def test_get_all(self, mock_pager, mock_server,
mock_tableau_auth):
assert jobs == mock_pager.return_value
mock_pager.assert_called_once_with(mock_server.return_value.jobs.get)
+
+ @patch('airflow.providers.tableau.hooks.tableau.Server')
+ def test_get_job_status(self, mock_tableau_server):
+ """
+ Test get job status
+ """
+ # Test SUCCESS
+ mock_tableau_server.jobs.get_by_id.return_value.finish_code = 0
+ with TableauHook(tableau_conn_id='tableau_test_password') as
tableau_hook:
+ tableau_hook.server = mock_tableau_server
+ jobs_status = tableau_hook.get_job_status(job_id='j1')
+ assert jobs_status == TableauJobFinishCode.SUCCESS
+
+ # Test ERROR
+ mock_tableau_server.jobs.get_by_id.return_value.finish_code = 1
+ with TableauHook(tableau_conn_id='tableau_test_password') as
tableau_hook:
+ tableau_hook.server = mock_tableau_server
+ jobs_status = tableau_hook.get_job_status(job_id='j1')
+ assert jobs_status == TableauJobFinishCode.ERROR
+
+ @patch('airflow.providers.tableau.hooks.tableau.Server')
+ def test_wait_for_state(self, mock_tableau_server):
+ '''
+ Test wait_for_state
+ '''
+ # Test SUCCESS Positive
+ with TableauHook(tableau_conn_id='tableau_test_password') as
tableau_hook:
+ tableau_hook.get_job_status = MagicMock(
+ name='get_job_status',
+ side_effect=[TableauJobFinishCode.PENDING,
TableauJobFinishCode.SUCCESS],
+ )
+ assert tableau_hook.wait_for_state(
+ job_id='j1', target_state=TableauJobFinishCode.SUCCESS,
check_interval=1
+ )
+
+ # Test SUCCESS Negative
+ with TableauHook(tableau_conn_id='tableau_test_password') as
tableau_hook:
+ tableau_hook.get_job_status = MagicMock(
+ name='get_job_status',
+ side_effect=[
+ TableauJobFinishCode.PENDING,
+ TableauJobFinishCode.PENDING,
+ TableauJobFinishCode.ERROR,
+ ],
+ )
+ assert not tableau_hook.wait_for_state(
+ job_id='j1', target_state=TableauJobFinishCode.SUCCESS,
check_interval=1
+ )
+
+ # Test ERROR Positive
+ with TableauHook(tableau_conn_id='tableau_test_password') as
tableau_hook:
+ tableau_hook.get_job_status = MagicMock(
+ name='get_job_status',
+ side_effect=[
+ TableauJobFinishCode.PENDING,
+ TableauJobFinishCode.PENDING,
+ TableauJobFinishCode.ERROR,
+ ],
+ )
+ assert tableau_hook.wait_for_state(
+ job_id='j1', target_state=TableauJobFinishCode.ERROR,
check_interval=1
+ )
+
+ # Test PENDING Positive
+ with TableauHook(tableau_conn_id='tableau_test_password') as
tableau_hook:
+ tableau_hook.get_job_status = MagicMock(
+ name='get_job_status',
+ side_effect=[
+ TableauJobFinishCode.PENDING,
+ TableauJobFinishCode.PENDING,
+ TableauJobFinishCode.ERROR,
+ ],
Review comment:
<del> I wanted to simulate a more realistic case, just to be more secure
that everything was ok. </del>
I read wrong before. You're right, in this case, it is not necessary.
##########
File path: airflow/providers/tableau/hooks/tableau.py
##########
@@ -133,3 +139,37 @@ def get_all(self, resource_name: str) -> Pager:
except AttributeError:
raise ValueError(f"Resource name {resource_name} is not found.")
return Pager(resource.get)
+
+ def get_job_status(self, job_id: str) -> Enum:
Review comment:
Thank you for your suggestion. With `TableauJobFinishCode` in docs it is
more clear. I changed it also in `wait_for_state` function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
