potiuk commented on a change in pull request #5141: [AIRFLOW-4362] Fix
test_execution_limited_parallelism
URL: https://github.com/apache/airflow/pull/5141#discussion_r277127930
##########
File path: tests/executors/test_local_executor.py
##########
@@ -55,14 +55,16 @@ def execution_parallelism(self, parallelism=0):
else:
executor.end()
- for i in range(self.TEST_SUCCESS_COMMANDS):
- key = success_key.format(i)
- self.assertTrue(executor.event_buffer[key], State.SUCCESS)
- self.assertTrue(executor.event_buffer['fail'], State.FAILED)
+ if isinstance(executor.impl, LocalExecutor._LimitedParallelism):
Review comment:
@milton0825 - Could you please describe what problem we are actually
solving here (either in the commit message or in the JIRA issue). I am not sure
what is the reasoning for that change and having some context will be useful to
understand if it works as intended.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
