ferruzzi commented on pull request #16571: URL: https://github.com/apache/airflow/pull/16571#issuecomment-883716102
Pushed the system tests. They will all skip because the logic for passing/parsing the credentials is not implemented in `provide_aws_context()`, but that feels like it would be better served with a new PR rather than tacking it on to this one. It's been a long conversation but I think that covers everything I'm aware of so far except for two discussions: 1. (https://github.com/apache/airflow/pull/16571#discussion_r656029075) The hooks use camelCase field/param names to match the API endpoints they call. That is easy to change if you want it changed, but I did it to keep the hooks as close to a 1:1 map tot he API calls as possible. 2. (https://github.com/apache/airflow/pull/16571#discussion_r660443571) ashb had asked if we needed the `list` and `describe` operators. mik-laj commented with a potential usecase though it may have been a bit of a stretch. I can remove them if anyone wants them gone, but it feels like a shame since they are already implemented. ((sunken cost fallacy strikes again)) In addition, it has already been discussed (here and on the Slack) and we determined that the token rotation will be improved after this is implemented. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
