uranusjr commented on pull request #17125:
URL: https://github.com/apache/airflow/pull/17125#issuecomment-884042661


   We can’t just remove functionality due to backward compatibility policy—we 
could deprecate it, but still need to keep the logic. So something like this is 
probably good enough:
   
   ```python
   verify = self.conn.extra_dejson.get('verify', True)
   if isinstance(verify, number.Number):  # Also allow e.g. {"verify": 1}
       verify = bool(verify)
   elif isinstance(verify, str):
       warnings.warn("blah blah parsing verify from a string is deprecated", 
DeprecationWarning)
       from distutils.util import strtobool
       verify = strtobool(verify)
   else:
       raise TypeError(f"verify needs to be a number, not {verify!r}")
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to