kaxil commented on a change in pull request #17121:
URL: https://github.com/apache/airflow/pull/17121#discussion_r673959161
##########
File path: airflow/dag_processing/processor.py
##########
@@ -647,3 +650,17 @@ def process_file(
self.log.exception("Error logging import errors!")
return len(dagbag.dags), len(dagbag.import_errors)
+
+ def _deactivate_missing_dags(self, session: Session, dagbag: DagBag,
file_path: str) -> None:
+ for dag in (
+ session.query(DagModel)
+ .filter(DagModel.fileloc == file_path)
+ .filter(DagModel.is_active)
+ .filter(~DagModel.dag_id.in_(dagbag.dag_ids))
+ .all()
Review comment:
You can chain this filter -- they use logical AND
```suggestion
session.query(DagModel)
.filter(DagModel.fileloc == file_path, DagModel.is_active,
~DagModel.dag_id.in_(dagbag.dag_ids))
.all()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
