[ 
https://issues.apache.org/jira/browse/AIRFLOW-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822468#comment-16822468
 ] 

ASF GitHub Bot commented on AIRFLOW-4362:
-----------------------------------------

potiuk commented on pull request #5141: [AIRFLOW-4362] Fix 
test_execution_limited_parallelism
URL: https://github.com/apache/airflow/pull/5141
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Fix test_execution_limited_parallelism logic
> --------------------------------------------
>
>                 Key: AIRFLOW-4362
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4362
>             Project: Apache Airflow
>          Issue Type: New Feature
>            Reporter: Chao-Han Tsai
>            Assignee: Chao-Han Tsai
>            Priority: Major
>
> - We should use `assertEqual` to compare two items instead of using 
> `assertTrue`.
> - Ensure that all queues are empty after the executer ends. So when 
> executor.end()is called, it ensures that the queues are empty with: 
> https://github.com/apache/airflow/blob/master/airflow/executors/local_executor.py#L195-L196
>  
> https://github.com/apache/airflow/blob/master/airflow/executors/local_executor.py#L205
>  So I am adding assertion in the test to ensure that.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to