jedcunningham commented on a change in pull request #17169:
URL: https://github.com/apache/airflow/pull/17169#discussion_r675141640
##########
File path: scripts/ci/libraries/_build_images.sh
##########
@@ -410,12 +410,15 @@ function build_images::get_docker_image_names() {
# Also enable experimental features of docker (we need `docker manifest`
command)
function build_images::configure_docker_registry() {
local token="${GITHUB_TOKEN}"
- if [[ -z "${token}" ]] ; then
+ if [[ -z "${token}" ]]; then
verbosity::print_info
verbosity::print_info "Skip logging in to GitHub Registry. No Token
available!"
verbosity::print_info
- fi
- if [[ -n "${token}" ]]; then
+ elif [[ ${AIRFLOW_LOGIN_TO_GITHUB_REGISTRY=} != "true" ]]; then
+ verbosity::print_info
+ verbosity::print_info "Skip logging in to GitHub Registry.
AIRFLOW_LOGIN_TO_GITHUB_REGISTRY != true"
+ verbosity::print_info
+ elif [[ -n "${token}" ]]; then
Review comment:
```suggestion
elif [[ -n "${token}" ]]; then
```
nit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
