OmerJog commented on issue #5118: [AIRFLOW-4315] Add monitoring API's to airflow
URL: https://github.com/apache/airflow/pull/5118#issuecomment-485245863
 
 
   @raviagarwalunravel note the flake8 errors:
   ```
   ./airflow/www/api/experimental/endpoints.py:58:55: E711 comparison to None 
should be 'if cond is not None:'
   ./airflow/www/api/experimental/endpoints.py:58:57: E225 missing whitespace 
around operator
   ./airflow/www/api/experimental/endpoints.py:68:22: E225 missing whitespace 
around operator
   ./airflow/www/api/experimental/endpoints.py:72:13: E123 closing bracket does 
not match indentation of opening bracket's line
   ./airflow/www/api/experimental/endpoints.py:77:89: F821 undefined name 
'task_log_reader'
   ./airflow/www/api/experimental/endpoints.py:77:111: E501 line too long (113 
> 110 characters)
   ./airflow/www/api/experimental/endpoints.py:78:9: F821 undefined name 
'metadata'
   ./airflow/www/api/experimental/endpoints.py:79:68: F821 undefined name 
'metadata'
   ./airflow/www/api/experimental/endpoints.py:82:5: E303 too many blank lines 
(2)
   ./airflow/www/api/experimental/endpoints.py:92:111: E501 line too long (183 
> 110 characters)
   ./airflow/www/api/experimental/endpoints.py:93:111: E501 line too long (181 
> 110 characters)
   ./airflow/www/api/experimental/endpoints.py:103:111: E501 line too long (178 
> 110 characters)
   ./airflow/www/api/experimental/endpoints.py:103:136: E231 missing whitespace 
after ','
   ./airflow/www/api/experimental/endpoints.py:107:1: E302 expected 2 blank 
lines, found 1
   ./airflow/www/api/experimental/endpoints.py:114:111: E501 line too long (183 
> 110 characters)
   ./airflow/www/api/experimental/endpoints.py:115:111: E501 line too long (181 
> 110 characters)
   ./airflow/www/api/experimental/endpoints.py:118:36: W291 trailing whitespace
   ./airflow/www/api/experimental/endpoints.py:128:13: E128 continuation line 
under-indented for visual indent
   ./airflow/www/api/experimental/endpoints.py:128:56: E231 missing whitespace 
after ','
   ./airflow/www/api/experimental/endpoints.py:128:111: E501 line too long (115 
> 110 characters)
   ./airflow/www/api/experimental/endpoints.py:132:1: E302 expected 2 blank 
lines, found 1
   ./airflow/www/api/experimental/endpoints.py:145:1: E302 expected 2 blank 
lines, found 1
   ./airflow/www/api/experimental/endpoints.py:160:1: E302 expected 2 blank 
lines, found 1
   ./airflow/www/api/experimental/endpoints.py:235:111: E501 line too long (183 
> 110 characters)
   ./airflow/www/api/experimental/endpoints.py:236:111: E501 line too long (181 
> 110 characters)
   ./airflow/www/api/experimental/endpoints.py:247:17: E128 continuation line 
under-indented for visual indent
   ./airflow/www/api/experimental/endpoints.py:247:60: E231 missing whitespace 
after ','
   ./airflow/www/api/experimental/endpoints.py:294:1: E302 expected 2 blank 
lines, found 1
   ./airflow/www/api/experimental/endpoints.py:373:28: E231 missing whitespace 
after ':'
   ./airflow/www/api/experimental/endpoints.py:374:30: E231 missing whitespace 
after ':'
   ./airflow/www/api/experimental/endpoints.py:375:9: E123 closing bracket does 
not match indentation of opening bracket's line
   ./airflow/api/common/experimental/get_all_dag_runs.py:21:1: F401 
'airflow.exceptions.AirflowException' imported but unused
   ./airflow/api/common/experimental/get_all_dag_runs.py:26:45: E231 missing 
whitespace after ','
   ./airflow/api/common/experimental/get_all_dag_runs.py:26:111: E501 line too 
long (122 > 110 characters)
   ./airflow/api/common/experimental/get_all_dag_runs.py:31:111: E501 line too 
long (117 > 110 characters)
   ./airflow/api/common/experimental/get_all_dag_runs.py:45:13: E128 
continuation line under-indented for visual indent
   ./airflow/api/common/experimental/get_all_dag_runs.py:54:24: E241 multiple 
spaces after ':'
   ./airflow/api/common/experimental/get_all_dag_runs.py:55:28: E127 
continuation line over-indented for visual indent
   ./airflow/api/common/experimental/get_dag_runs.py:26:36: E231 missing 
whitespace after ','
   ./airflow/api/common/experimental/get_dag_runs.py:26:111: E501 line too long 
(112 > 110 characters)
   ./airflow/api/common/experimental/get_dag_runs.py:27:9: E128 continuation 
line under-indented for visual indent
   ./airflow/api/common/experimental/get_dag_runs.py:32:111: E501 line too long 
(117 > 110 characters)
   ./airflow/api/common/experimental/get_dag_runs.py:53:13: E128 continuation 
line under-indented for visual indent
   ./airflow/api/common/experimental/get_dag_runs.py:54:13: E128 continuation 
line under-indented for visual indent
   ./airflow/api/common/experimental/get_dag_runs.py:63:24: E241 multiple 
spaces after ':'
   ./airflow/api/common/experimental/get_dag_runs.py:64:28: E127 continuation 
line over-indented for visual indent
   ./airflow/api/common/experimental/get_task.py:42:1: E302 expected 2 blank 
lines, found 1
   ./airflow/api/common/experimental/get_task.py:47:13: E128 continuation line 
under-indented for visual indent
   ./airflow/api/common/experimental/get_task.py:48:13: E128 continuation line 
under-indented for visual indent
   ./airflow/api/common/experimental/get_task.py:50:32: E231 missing whitespace 
after ':'
   ./airflow/api/common/experimental/get_task.py:51:34: E231 missing whitespace 
after ':'
   ./airflow/api/common/experimental/get_task.py:52:13: E123 closing bracket 
does not match indentation of opening bracket's line
   ./airflow/api/common/experimental/get_task.py:53:12: F821 undefined name 
'AirflowException'
   ./airflow/api/common/experimental/get_dags.py:19:1: F401 'flask.url_for' 
imported but unused
   ./airflow/api/common/experimental/get_dags.py:21:1: F401 
'airflow.models.DagRun' imported but unused
   ./airflow/api/common/experimental/get_dags.py:24:1: E302 expected 2 blank 
lines, found 1
   ./airflow/api/common/experimental/get_dags.py:33:35: E225 missing whitespace 
around operator
   ./airflow/api/common/experimental/get_dags.py:51:27: E203 whitespace before 
':'
   ./airflow/api/common/experimental/get_dags.py:52:17: W503 line break before 
binary operator
   ./airflow/api/common/experimental/get_dags.py:52:18: E225 missing whitespace 
around operator
   ./airflow/api/common/experimental/get_dags.py:53:17: W503 line break before 
binary operator
   ./airflow/api/common/experimental/get_dags.py:53:18: E225 missing whitespace 
around operator
   ./airflow/api/common/experimental/get_dags.py:54:17: W503 line break before 
binary operator
   ./airflow/api/common/experimental/get_dags.py:54:18: E225 missing whitespace 
around operator
   ./airflow/api/common/experimental/get_dags.py:55:17: E123 closing bracket 
does not match indentation of opening bracket's line
   ./airflow/api/common/experimental/get_dags.py:56:13: E123 closing bracket 
does not match indentation of opening bracket's line
   ./airflow/api/common/experimental/get_dags.py:58:26: E201 whitespace after 
'['
   ./airflow/api/common/experimental/get_dags.py:58:83: E202 whitespace before 
']'
   ./airflow/api/common/experimental/get_dags.py:58:98: E711 comparison to None 
should be 'if cond is not None:'
   ./airflow/api/common/experimental/get_dags.py:58:98: E225 missing whitespace 
around operator
   ./airflow/api/common/experimental/get_dags.py:58:111: E501 line too long 
(117 > 110 characters)
   ./airflow/api/common/experimental/get_dags.py:59:11: E271 multiple spaces 
after keyword
   ./airflow/api/common/experimental/get_tasks.py:20:1: F401 
'airflow.exceptions.TaskNotFound' imported but unused
   ./airflow/api/common/experimental/get_task_logs.py:64:5: E265 block comment 
should start with '# '
   ./airflow/api/common/experimental/get_task_logs.py:75:1: W293 blank line 
contains whitespace
   ./airflow/api/common/experimental/get_task_logs.py:85:5: F841 local variable 
'message' is assigned to but never used
   ./airflow/api/common/experimental/get_task_logs.py:86:5: E265 block comment 
should start with '# '
   ./airflow/api/common/experimental/get_dag.py:19:1: F401 'flask.url_for' 
imported but unused
   ./airflow/api/common/experimental/get_dag.py:22:1: F401 
'airflow.models.DagBag' imported but unused
   ./airflow/api/common/experimental/get_dag.py:22:1: F401 
'airflow.models.DagRun' imported but unused
   ./airflow/api/common/experimental/get_dag.py:32:26: E703 statement ends with 
a semicolon
   ./airflow/api/common/experimental/get_dag.py:35:14: E211 whitespace before 
'('
   ./airflow/api/common/experimental/get_all_task_instances.py:19:1: F401 
'flask.url_for' imported but unused
   ./airflow/api/common/experimental/get_all_task_instances.py:21:1: F401 
'airflow.exceptions.AirflowException' imported but unused
   ./airflow/api/common/experimental/get_all_task_instances.py:26:51: E231 
missing whitespace after ','
   ./airflow/api/common/experimental/get_all_task_instances.py:27:9: E128 
continuation line under-indented for visual indent
   ./airflow/api/common/experimental/get_all_task_instances.py:34:111: E501 
line too long (117 > 110 characters)
   ./airflow/api/common/experimental/get_all_task_instances.py:47:13: E128 
continuation line under-indented for visual indent
   ./airflow/api/common/experimental/get_all_task_instances.py:47:111: E501 
line too long (117 > 110 characters)
   ./airflow/api/common/experimental/get_all_task_instances.py:49:13: E128 
continuation line under-indented for visual indent
   ./airflow/api/common/experimental/get_all_task_instances.py:50:13: E128 
continuation line under-indented for visual indent
   ./airflow/api/common/experimental/get_all_task_instances.py:53:1: W293 blank 
line contains whitespace
   ./airflow/api/common/experimental/get_all_task_instances.py:55:5: E303 too 
many blank lines (2)
   ./airflow/models/dagrun.py:118:26: E231 missing whitespace after ','
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to