uranusjr commented on a change in pull request #17122:
URL: https://github.com/apache/airflow/pull/17122#discussion_r678088508



##########
File path: airflow/api_connexion/openapi/v1.yaml
##########
@@ -1875,17 +1875,26 @@ components:
         dag_id:
           type: string
           readOnly: true
-        execution_date:
-          description: >
-            The execution date. This is the time when the DAG run should be 
started according
-            to the DAG definition.
+        schedule_date:
+          type: string
+          nullable: true
+          description: |
+            The logical date (schedule date, previously called execution 
date). This is the time or interval
+            covered by this DAG run, according to the DAG definition.
 
             The value of this field can be set only when creating the object. 
If you try to modify the
             field of an existing object, the request fails with an BAD_REQUEST 
error.
 
             This together with DAG_ID are a unique key.
+          format: date-time
+        execution_date:
           type: string
+          nullable: true
+          description: |
+            The execution date. This is the same as schedule_date, kept for 
backwards compatibility.
+            A request with both schedule_date and this field will fail with an 
BAD_REQUEST error.

Review comment:
       You got me here 😆 I was undecided between the two and ended up doing 
different things in the two places. I’ll change the API spec to match 
implementation for now (i.e. only fail if values differ).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to