potiuk commented on a change in pull request #5145: [AIRFLOW-4379] Remove duplicate code & Add validation in gcs_to_gcs.py URL: https://github.com/apache/airflow/pull/5145#discussion_r277212336
########## File path: tests/contrib/operators/test_gcs_to_gcs_operator.py ########## @@ -33,6 +33,7 @@ SOURCE_OBJECT_3 = 'test*object' SOURCE_OBJECT_4 = 'test_object*.txt' SOURCE_OBJECT_5 = 'test_object.txt' +SOURCE_OBJECT_6 = 'csv/*/test_*.csv' Review comment: I prefer naming those kind of constants with meaningful names. Proposals: SOURCE_OBJECT_1 = '*test_object' -> SOURCE_OBJECT_ASTERISK_PREFIX SOURCE_OBJECT_2 = 'test_object*' -> SOURCE_OBJECT_ASTERISK_SUFFIX SOURCE_OBJECT_3 = 'test*object' -> SOURCE_OBJECT_ASTERISK_MIDDLE SOURCE_OBJECT_4 = 'test_object*.txt' -> SOURCE_OBJECT_ASTERISK_FILENAME SOURCE_OBJECT_5 = 'test_object.txt' -> SOURCE_OBJECT_NO_ASTERISK SOURCE_OBJECT_6 = 'csv/*/test_*.csv' -> SOURCE_OBJECT_MULTIPLE_ASTERISKS ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
